-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[text field] Fix inconsistent input caret position on focus #47340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shalini-saloni
wants to merge
8
commits into
mui:master
Choose a base branch
from
shalini-saloni:textfield_carret_position-branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−8
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
34924cf
fix(InputBase): restore caret position when clicking wrapper
shalini-saloni 27b3919
fix(InputBase): restore caret position when clicking wrapper
shalini-saloni ac762b2
fix(InputBase): prevent caret from resetting when clicking wrapper
shalini-saloni 872fb20
fix(InputBase): prevent caret from resetting when clicking wrapper
shalini-saloni 67f542f
Merge branch 'master' into textfield_carret_position-branch
shalini-saloni 0dcf7b5
[material][InputBase] Fix caret position reset when clicking on wrapper
shalini-saloni bfd6104
test(InputBase): add caret position preservation test
shalini-saloni b2362ce
Merge branch 'master' into textfield_carret_position-branch
shalini-saloni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not use instanceof as it's inconsistent across window contexts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback!
I’ve removed the instanceof check and replaced it with a safer, window-agnostic guard (checking for .setSelectionRange and .focus).
The updated approach no longer depends on instanceof and works correctly across window contexts.