[docs-infra] Add Cookie Banner and Analytics Provider #47445
+249
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav-is
added
type: enhancement
Netlify deploy previewhttps://deploy-preview-47445--material-ui.netlify.app/ Bundle size report
|
Member
|
@noraleonte can you provide any feedback on the design side? Thank you! :) Also, let's follow https://mui.com/material-ui/react-dialog/#non-modal-dialog for the interactions. |
Member
|
Would probably be a good idea to try this out with X before merging. (You can just point |
Janpot
reviewed
Jan 14, 2026
| const getDoNotTrackServerSnapshot = () => true; // Assume DNT until we know the actual value | ||
|
|
||
| function useDoNotTrack(): boolean { | ||
| return React.useSyncExternalStore( |
Member
There was a problem hiding this comment.
Perhaps add a comment that we use this to avoid hydration errors?
Janpot
reviewed
Jan 14, 2026
| type ConsentStatus = 'analytics' | 'essential' | null; | ||
|
|
||
| function getDoNotTrack(): boolean { | ||
| if (typeof window === 'undefined') { |
Member
There was a problem hiding this comment.
Can this ever happen if we provide getServerSnapshot?
Janpot
approved these changes
Jan 14, 2026
noraleonte
reviewed
Jan 14, 2026
Co-authored-by: Nora <[email protected]> Signed-off-by: Connor Davis <[email protected]>
Signed-off-by: Connor Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the init script for https://www.apollo.io/ and asks for consent from the user:
Essential only does not send data to Apollo and Google Analytics is set to
analytics_storage: 'denied'.These are the defaults Google defines
Do we need to enable these other permissions? If so should we alter the message we display?
Preview URL