[focus-trap] Compute activeElement inside loopFocus on every keydown
#47566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
scope: focus trap
Netlify deploy previewhttps://deploy-preview-47566--material-ui.netlify.app/ Bundle size report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #47380.
Resolves issue #47423 (comment).
The
activeElementis captured once when the effect runs, and then reused for every later keydown.Because that
activeElementvalue is stale, if the dialog initially focusedrootRef.current(common when it opens), then every laterShift+Tabkeydown still thinks the origin is the root so it forces focus tosentinelEnd, which then causes the trap to wrap focus to the last tabbable element ("Agree"), making it look "stuck".Before: https://mui.com/material-ui/react-dialog/#transitions
After: https://deploy-preview-47566--material-ui.netlify.app/material-ui/react-dialog/#transitions