[backdrop] Remove aria-hidden by default#47798
Merged
silviuaavram merged 2 commits intomui:masterfrom Feb 23, 2026
Merged
Conversation
1 task
Netlify deploy previewBundle size report
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Backdrop accessibility defaults to address issue #33146 by removing the unconditional aria-hidden attribute, relying on Modal’s useModal-provided props to apply aria-hidden only where appropriate (e.g., Modal backdrops).
Changes:
- Remove default
aria-hiddenfromBackdrop’s root slot to avoid hiding Backdrop children from assistive tech. - Shift responsibility for
aria-hiddento Modal’s backdrop props path (viauseModal.getBackdropProps), aligning with the issue’s intent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Looks good. Only the entry needs to be added in the "upgrade to v9" guide.
8898c2b to
6be0bfa
Compare
ZeeshanTamboli
approved these changes
Feb 19, 2026
6be0bfa to
d72a0d3
Compare
d72a0d3 to
4ef0c36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's bascially #34691 from @chapmanm3 but opened this PR because:
useModalso no need to add it again there.Fixes #33146