-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[pickers] Remove PickersDay and promote PickerDay2 as a replacement
#21739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michelengelen
wants to merge
108
commits into
mui:master
Choose a base branch
from
michelengelen:bugfix/21615-misaligned-days-in-picker
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
108 commits
Select commit
Hold shift + click to select a range
7167a58
set `display: block` for `PickersDay` component style
michelengelen 3b6e1a3
Merge branch 'master' into bugfix/21615-misaligned-days-in-picker
michelengelen bd965bc
adjusted display property for weekpicker demo
michelengelen be24115
Merge branch 'master' into bugfix/21615-misaligned-days-in-picker
michelengelen 0f20f67
remove `PickerDay2` and `DateRangePickerDay2` from `slots` and corres…
michelengelen 9c64d75
Merge branch 'master' into bugfix/21615-misaligned-days-in-picker
michelengelen 2afb06a
Merge remote-tracking branch 'origin/bugfix/21615-misaligned-days-in-…
michelengelen 6cef43a
fixed variable declaration
michelengelen abc2d03
fixed docs preview
michelengelen c8ea116
renamed `PickersDay` to `PickerDay` for naming consistency
michelengelen 8cd164f
updated docs and api
michelengelen 2d7a6ac
Merge remote-tracking branch 'upstream/master' into bugfix/21615-misa…
michelengelen 524fcfe
updated incorrect component path
michelengelen e18f5f5
re-added `disableMargin` prop to `PickerDay` component
michelengelen 717f11a
re-added `disableMargin` prop to `DateRangePickerDay` component
michelengelen 28b3778
ran docs script
michelengelen 4f58898
Merge remote-tracking branch 'upstream/master' into bugfix/21615-misa…
michelengelen 933c216
fixed broken link in docs
michelengelen be45568
added `rename-pickers-day` codemod to rename `PickersDay` to `PickerD…
michelengelen cf93797
fixed linting error
michelengelen 07c5d0a
fixed typescript error in codemod
michelengelen b712965
updated theme overrides for `PickerDay` and improved TypeScript defin…
michelengelen 43e6cc3
fix typescript
michelengelen a5a3517
updated dimensions to align with the new day
michelengelen cc59b12
reverted unrelated change in date-fns adapter
michelengelen 0d7bdfe
Merge branch 'master' into bugfix/21615-misaligned-days-in-picker
michelengelen 17ab65d
Merge branch 'master' into bugfix/21615-misaligned-days-in-picker
michelengelen 02d5ffc
fixed unwanted change
michelengelen 1d7a55a
removed unneeded variables from CSS
michelengelen 10dee20
Merge remote-tracking branch 'origin/bugfix/21615-misaligned-days-in-…
michelengelen d7ace3c
added `isDayFillerCell` prop to `PickerDay` and `DateRangePickerDay` …
michelengelen 89dc66d
fixed overrides resolver bug for `dayOutsideMonth`
michelengelen 223d982
re-added `DateRangePickerDayClasses` type export to barrel file
michelengelen c2dc041
re-added `useLicenseVerifier` to `DateRangePickerDay` component
michelengelen 40fa16e
removed obsolete `DateRangePickerDay` classes and updated usages
michelengelen b439468
extended codemod to handle template literals for `MuiPickersDay` to `…
michelengelen 257cf53
added codemod for `PickerDay2` and `DateRangePickerDay2` removal and …
michelengelen e50ac3f
properly hooked up `disableMargin` prop
michelengelen b0a7ed5
removed unused `hidden` prop from destructure call
michelengelen 2a53991
removed unused `borderOffset` style in `DateRangePickerDay`
michelengelen e98b371
updated `isDaySelected` logic in `DateRangePickerDay` to include indi…
michelengelen f5019f7
re-added API and demo links for `PickerDay` and `DateRangePickerDay` …
michelengelen d7e1715
added support for `role` prop in `PickerDay` component
michelengelen c63a785
Merge remote-tracking branch 'upstream/master' into bugfix/21615-misa…
michelengelen 60da174
fixed codemod typescript issues
michelengelen 8deb792
fixed linting error
michelengelen fe851af
fixed inverted condition in `overridesResolver`
michelengelen 20a920b
added style overrides support and tests in `DateRangePickerDay` compo…
michelengelen 84dfe84
updated `data-testid` logic for `DateRangePickerDay`, replacing neste…
michelengelen f34fd95
updated codemod to clean up empty `slots` props and handle variable-a…
michelengelen ef1586e
Merge remote-tracking branch 'upstream/master' into bugfix/21615-misa…
michelengelen 11d87a2
fix language linting
michelengelen 4b56acc
updated docs links
michelengelen d9c6d9c
updated `onClick` event type in `PickerDay` and `DateRangePickerDay` …
michelengelen fec2670
updated migration guide: clarified `DateRangePickerDay` margins, rena…
michelengelen cb53e74
added codemod to rename class keys in `PickerDay` and `DateRangePicke…
michelengelen d0e0290
clarified `data-testid` changes in migration guide and their impact o…
michelengelen b857449
re-added correct `PickerDay` entry
michelengelen 10223ba
added codemod to rename `PickerDay2` and `DateRangePickerDay2` to `Pi…
michelengelen d5cbca5
first iteration on the customtheme adjustment
michelengelen 9a72b99
Updated style overrides and class usage in tests for `PickerDay` and …
michelengelen 185ae39
fixed the custom theme for the picker overview showcase
michelengelen e0bf2ad
removed `disableMargin` prop from `PickerDay` and `DateRangePickerDay…
michelengelen d311c21
fixed codemod tests
michelengelen 3417afe
fixed drag n drop
michelengelen dc07d86
Updated codemod logic and tests for picker components to rename class…
michelengelen c3ca8f6
fix dragging by solidifying the date comparison in drag handler
michelengelen e89671d
fix typescript
michelengelen e40e1db
fixed tests
michelengelen b349416
[pickers] Merge duplicate styleOverrides in rename-picker-classes cod…
michelengelen 548205e
[pickers] Make isFirstVisibleCell and isLastVisibleCell optional props
michelengelen 9707126
[pickers] Restrict string replacement to MUI-prefixed class names in …
michelengelen 2496a38
[pickers] Clean up empty slots prop and variable in remove-picker-day…
michelengelen c00458f
[pickers] Add remove-disable-margin codemod
michelengelen 216dd62
[pickers] Document `day` slot and updates to `PickerDay` component st…
michelengelen 51cd345
[pickers] Adjust `PickerDay` and `DateRangePickerDay` styles to align…
michelengelen e3d9e26
[pickers] Remove support for `disableMargin` and related styles
michelengelen dd2e7e7
[pickers] Clarify `showDaysOutsideCurrentMonth` prop behavior and def…
michelengelen 35cc804
[pickers] Standardize and clarify `DateRangePickerDayClasses` propert…
michelengelen 722ce3d
[pickers] Export `DAY_SIZE` and update `DAY_RANGE_SIZE` in `x-date-pi…
michelengelen 0e9b33d
Update packages/x-date-pickers/src/PickerDay/PickerDay.types.ts
michelengelen 0539f63
[pickers] Add `flex: 1` to `PickerDay` to improve layout consistency
michelengelen a9e8922
Merge remote-tracking branch 'origin/bugfix/21615-misaligned-days-in-…
michelengelen e4c0d6a
[pickers] Enhance `showDaysOutsideCurrentMonth` prop logic and add da…
michelengelen c47e909
prettier
michelengelen c3f8489
make linters happy
michelengelen 4b665a3
added missing line in test file
michelengelen 1e423e9
Merge branch 'master' into bugfix/21615-misaligned-days-in-picker
LukasTy e567d9c
Fix outline color
LukasTy 3ed4da0
Align `minHeight`
LukasTy 7981321
Fix height calculation in different heights (margin is stable)
LukasTy 87c7df1
Prefer CSS Variables over explicit `width` and `height`
LukasTy 2041898
Remove prop breaking other cases
LukasTy 899a41c
Bring back previous styling examples
LukasTy 671bc8e
Merge branch 'master' into bugfix/21615-misaligned-days-in-picker
LukasTy 6dbf007
Merge branch 'master' into bugfix/21615-misaligned-days-in-picker
LukasTy 9d05474
tweak
LukasTy e83a196
Revert unrelated changes
LukasTy 94787d3
Revert `onDaySelect` to required
LukasTy 9cd91ae
rebuild
LukasTy 38b49e0
Revert `PickerDay` classes to what we currently have with `PickerDay2…
LukasTy 3698c4d
Fix mid-selection styles and some cleanup
LukasTy 89a5937
fix
LukasTy eaf01be
Address code review: cover `preset-safe` with tests
LukasTy 0249603
Update `remove-disable-margin` codemod to prefer updating to a CSS Va…
LukasTy d2409b4
Add Pickers codemod master readme
LukasTy e9daf31
Merge branch 'master' into bugfix/21615-misaligned-days-in-picker
LukasTy 2096740
Fix codemod tests
LukasTy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.