Skip to content

Change RelayTests to recognise the tristate multihop UI#10041

Merged
rablador merged 1 commit intomainfrom
ios-1552-multihop-settings-ui-tests
Mar 24, 2026
Merged

Change RelayTests to recognise the tristate multihop UI#10041
rablador merged 1 commit intomainfrom
ios-1552-multihop-settings-ui-tests

Conversation

@acb-mv
Copy link
Contributor

@acb-mv acb-mv commented Mar 20, 2026

This changes the Text elements in the multihop UI to Button elements, and adapts the UI tests to use those.


This change is Reviewable

@acb-mv acb-mv requested a review from rablador March 20, 2026 09:45
@acb-mv acb-mv self-assigned this Mar 20, 2026
@acb-mv acb-mv added the iOS Issues related to iOS label Mar 20, 2026
@linear
Copy link

linear bot commented Mar 20, 2026

@github-actions
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

rablador
rablador previously approved these changes Mar 23, 2026
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on acb-mv).


ios/MullvadVPNUITests/Pages/MultihopPage.swift line 44 at r1 (raw file):

        return self
    }
    

Nit: Extra spaces

@rablador rablador force-pushed the ios-1552-multihop-settings-ui-tests branch from f6c8edc to adb95c5 Compare March 23, 2026 19:23
@rablador rablador force-pushed the ios-1552-multihop-settings-ui-tests branch from adb95c5 to 16a0033 Compare March 23, 2026 19:41
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on acb-mv).

Copy link
Contributor

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@mojganii made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on acb-mv).

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on acb-mv).

@rablador rablador merged commit e7c0e47 into main Mar 24, 2026
21 of 23 checks passed
@rablador rablador deleted the ios-1552-multihop-settings-ui-tests branch March 24, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iOS Issues related to iOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants