Add a --daemon-only build option#10050
Conversation
--daemon-only build option
MarkusPettersson98
left a comment
There was a problem hiding this comment.
@MarkusPettersson98 reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: 3 of 8 files reviewed, 3 unresolved discussions (waiting on braydonf).
build.sh line 37 at r1 (raw file):
GOTATUN="false" # If only the daemon should be built. DAEMON_ONLY="false"
Suggestion:
# If only the daemon should be built and packaged separately (.deb and .rpm).
DAEMON_ONLY="false"build.sh line 388 at r2 (raw file):
cargo run -p mullvad-api --bin relay_list "${CARGO_ARGS[@]}" > build/relays.json function build_daemon_packages {
If the generated .deb and .rpm packages could be output to dist/, that would be great!
Code quote:
function build_daemon_packagesdist-assets/linux/daemon/postrm line 33 at r1 (raw file):
remove_symlinks ;; # yum remove passes a 0
⛏️ dnf has replaced yum nowadays, right? I know that the comment is copy-pasted from the existing after-remove script, but it could still be improved:)
Suggestion:
# dnf remove passes a 0
MarkusPettersson98
left a comment
There was a problem hiding this comment.
I think the code looks good!
@MarkusPettersson98 reviewed 5 files and made 1 comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on braydonf).
|
Okay great. I've updated it to output to |
MarkusPettersson98
left a comment
There was a problem hiding this comment.
@MarkusPettersson98 reviewed 5 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on braydonf).
402c88e to
d86f3db
Compare
|
I'm working on including Do you have everything you need then?:) |
|
Yup, great! Opened a PR that builds on that: #10078 |
Adds a
--daemon-onlybuild option for deb and rpm packages for CLI usage.This change is