Skip to content

Add a --daemon-only build option#10050

Merged
MarkusPettersson98 merged 4 commits intomullvad:mainfrom
braydonf:daemon-only
Mar 25, 2026
Merged

Add a --daemon-only build option#10050
MarkusPettersson98 merged 4 commits intomullvad:mainfrom
braydonf:daemon-only

Conversation

@braydonf
Copy link
Contributor

@braydonf braydonf commented Mar 22, 2026

Adds a --daemon-only build option for deb and rpm packages for CLI usage.


This change is Reviewable

@braydonf braydonf changed the title Add a `aemon-only build option Add a --daemon-only build option Mar 22, 2026
@MarkusPettersson98 MarkusPettersson98 self-requested a review March 23, 2026 09:37
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkusPettersson98 reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: 3 of 8 files reviewed, 3 unresolved discussions (waiting on braydonf).


build.sh line 37 at r1 (raw file):

GOTATUN="false"
# If only the daemon should be built.
DAEMON_ONLY="false"

Suggestion:

# If only the daemon should be built and packaged separately (.deb and .rpm).
DAEMON_ONLY="false"

build.sh line 388 at r2 (raw file):

cargo run -p mullvad-api --bin relay_list "${CARGO_ARGS[@]}" > build/relays.json

function build_daemon_packages {

If the generated .deb and .rpm packages could be output to dist/, that would be great!

Code quote:

function build_daemon_packages

dist-assets/linux/daemon/postrm line 33 at r1 (raw file):

    remove_symlinks
    ;;
  # yum remove passes a 0

⛏️ dnf has replaced yum nowadays, right? I know that the comment is copy-pasted from the existing after-remove script, but it could still be improved:)

Suggestion:

  # dnf remove passes a 0

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code looks good!

@MarkusPettersson98 reviewed 5 files and made 1 comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on braydonf).

@braydonf
Copy link
Contributor Author

Okay great. I've updated it to output to dist/. It will now also package for all specified targets, it was added in the process of getting filenames for the packages.

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Amazing work! 👏

@MarkusPettersson98 reviewed 5 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on braydonf).

@MarkusPettersson98 MarkusPettersson98 merged commit 575f908 into mullvad:main Mar 25, 2026
44 of 46 checks passed
@MarkusPettersson98
Copy link
Contributor

I'm working on including libmnl and libnftnl for riscv in another PR: #10076

Do you have everything you need then?:)

@braydonf
Copy link
Contributor Author

Yup, great! Opened a PR that builds on that: #10078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants