Display inactive servers in location list ios 1291#9799
Conversation
|
🚨 End to end tests failed. Please check the failed workflow run. |
5484db7 to
fbea7eb
Compare
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils).
ios/MullvadREST/Relay/RelaySelectorWrapper.swift line 50 at r1 (raw file):
} public func findCandidates(tunnelSettings: LatestTunnelSettings) throws -> RelayCandidates {
Now that we explicitly ask for inactive servers in this function we should probably add a function doc describing that this functions is mainly for the UI to query relays to show.
acb-mv
left a comment
There was a problem hiding this comment.
@acb-mv reviewed 7 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils).
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils).
pinkisemils
left a comment
There was a problem hiding this comment.
@pinkisemils made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador).
ios/MullvadREST/Relay/RelaySelectorWrapper.swift line 50 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Now that we explicitly ask for inactive servers in this function we should probably add a function doc describing that this functions is mainly for the UI to query relays to show.
Done.
rablador
left a comment
There was a problem hiding this comment.
@rablador resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved.
3219ecc to
76552c4
Compare
76552c4 to
fdf59bb
Compare
I've changed the relay selector to show inactive servers and changed the relay list view to show indicate inactive servers. This seems to work fine. The desktop app also shows a green dot for every active location - we should not do that.
This change is