Skip to content

Display inactive servers in location list ios 1291#9799

Merged
pinkisemils merged 2 commits intomainfrom
display-inactive-servers-in-location-list-ios-1291
Feb 10, 2026
Merged

Display inactive servers in location list ios 1291#9799
pinkisemils merged 2 commits intomainfrom
display-inactive-servers-in-location-list-ios-1291

Conversation

@pinkisemils
Copy link
Collaborator

@pinkisemils pinkisemils commented Feb 10, 2026

I've changed the relay selector to show inactive servers and changed the relay list view to show indicate inactive servers. This seems to work fine. The desktop app also shows a green dot for every active location - we should not do that.


This change is Reviewable

@linear
Copy link

linear bot commented Feb 10, 2026

@github-actions
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

@pinkisemils pinkisemils force-pushed the display-inactive-servers-in-location-list-ios-1291 branch from 5484db7 to fbea7eb Compare February 10, 2026 09:09
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils).


ios/MullvadREST/Relay/RelaySelectorWrapper.swift line 50 at r1 (raw file):

    }

    public func findCandidates(tunnelSettings: LatestTunnelSettings) throws -> RelayCandidates {

Now that we explicitly ask for inactive servers in this function we should probably add a function doc describing that this functions is mainly for the UI to query relays to show.

acb-mv
acb-mv previously approved these changes Feb 10, 2026
Copy link
Contributor

@acb-mv acb-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acb-mv reviewed 7 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils).

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils).

Copy link
Collaborator Author

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pinkisemils made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador).


ios/MullvadREST/Relay/RelaySelectorWrapper.swift line 50 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Now that we explicitly ask for inactive servers in this function we should probably add a function doc describing that this functions is mainly for the UI to query relays to show.

Done.

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@pinkisemils pinkisemils force-pushed the display-inactive-servers-in-location-list-ios-1291 branch from 3219ecc to 76552c4 Compare February 10, 2026 12:08
@pinkisemils pinkisemils force-pushed the display-inactive-servers-in-location-list-ios-1291 branch from 76552c4 to fdf59bb Compare February 10, 2026 12:09
@pinkisemils pinkisemils merged commit 5470762 into main Feb 10, 2026
15 checks passed
@pinkisemils pinkisemils deleted the display-inactive-servers-in-location-list-ios-1291 branch February 10, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants