Skip to content

Merge app, tile and service modules#9848

Merged
Pururun merged 5 commits intomainfrom
merge-app-and-service-modules-droid-1653
Feb 16, 2026
Merged

Merge app, tile and service modules#9848
Pururun merged 5 commits intomainfrom
merge-app-and-service-modules-droid-1653

Conversation

@Pururun
Copy link
Contributor

@Pururun Pururun commented Feb 13, 2026


This change is Reviewable

@Pururun Pururun requested a review from Rawa February 13, 2026 14:56
@Pururun Pururun added the Android Issues related to Android label Feb 13, 2026
@linear
Copy link

linear bot commented Feb 13, 2026

Copy link
Collaborator

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rawa partially reviewed 81 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun).


android/app/src/main/AndroidManifest.xml line 88 at r1 (raw file):

        <!-- Default -->
        <activity-alias
            android:name="net.mullvad.mullvadvpn.appearance.impl.obfuscation.MainActivityAltDefault"

Oh nice find. Is it possible to move these over to the modules manifest as well?

Rawa
Rawa previously approved these changes Feb 13, 2026
Copy link
Collaborator

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rawa partially reviewed 14 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.


android/app/src/main/AndroidManifest.xml line 88 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Oh nice find. Is it possible to move these over to the modules manifest as well?

🌟 👏

@Pururun Pururun force-pushed the merge-app-and-service-modules-droid-1653 branch from a8a5e3e to 8523c45 Compare February 13, 2026 15:40
Copy link
Contributor Author

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pururun made 1 comment.
Reviewable status: 74 of 88 files reviewed, 1 unresolved discussion (waiting on @Rawa).


android/app/src/main/AndroidManifest.xml line 88 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Oh nice find. Is it possible to move these over to the modules manifest as well?

Done.

Rawa
Rawa previously approved these changes Feb 13, 2026
Copy link
Collaborator

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rawa reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@Pururun Pururun force-pushed the merge-app-and-service-modules-droid-1653 branch from 8523c45 to 0433ec0 Compare February 13, 2026 15:48
Rawa
Rawa previously approved these changes Feb 13, 2026
Copy link
Collaborator

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rawa reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@Pururun Pururun force-pushed the merge-app-and-service-modules-droid-1653 branch from 0433ec0 to 1d4aaa8 Compare February 16, 2026 08:33
@Pururun Pururun force-pushed the merge-app-and-service-modules-droid-1653 branch from 8ffb4bb to 0787bf7 Compare February 16, 2026 08:54
@Pururun Pururun force-pushed the merge-app-and-service-modules-droid-1653 branch from 0d70b2a to 035a4a4 Compare February 16, 2026 09:39
Copy link
Collaborator

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rawa reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@Pururun Pururun force-pushed the merge-app-and-service-modules-droid-1653 branch from 035a4a4 to 37f5d02 Compare February 16, 2026 10:04
@Pururun Pururun merged commit 3408264 into main Feb 16, 2026
59 checks passed
@Pururun Pururun deleted the merge-app-and-service-modules-droid-1653 branch February 16, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android Issues related to Android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants