Conversation
acb-mv
left a comment
There was a problem hiding this comment.
@acb-mv reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved.
|
So the info icon was updated and I assumed this would be a global change |
rablador
left a comment
There was a problem hiding this comment.
It's not of main yet, but it will be there when my PR is merged.
@rablador reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved.
rablador
left a comment
There was a problem hiding this comment.
Ah, you're right.
@rablador made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved.
079e34b to
bde473a
Compare
rablador
left a comment
There was a problem hiding this comment.
I did look at the code and the notification settings should be opened when pressing that button. When testing it doesn't work for some reason.
@rablador reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved.
rablador
left a comment
There was a problem hiding this comment.
Seems to not work on sim, but fine on phone.
@rablador made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved.
bde473a to
de527e3
Compare
|
It's good |
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved.
de527e3 to
8e0dfb9
Compare
rablador
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved.
|
🚨 End to end tests failed. Please check the failed workflow run. |


this PR fixes these issues:
Open system settingsorEnable notificationsaccording to the usernotification authorization status like belowThis change is