Skip to content

Update text in onboarding notification#9864

Merged
rablador merged 1 commit intomainfrom
fix-on-boarding-leftover-issues-iOS
Feb 19, 2026
Merged

Update text in onboarding notification#9864
rablador merged 1 commit intomainfrom
fix-on-boarding-leftover-issues-iOS

Conversation

@mojganii
Copy link
Contributor

@mojganii mojganii commented Feb 17, 2026

this PR fixes these issues:

  • "!" icon should be the "i" info icon
  • The text above the button should be smaller size
  • the button text should be either of Open system settings or Enable notifications according to the usernotification authorization status like below
Screenshot 2026-02-17 at 13 55 36 Screenshot 2026-02-17 at 13 55 07

This change is Reviewable

@mojganii mojganii self-assigned this Feb 17, 2026
@mojganii mojganii added the iOS Issues related to iOS label Feb 17, 2026
acb-mv
acb-mv previously approved these changes Feb 17, 2026
Copy link
Contributor

@acb-mv acb-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@acb-mv reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@waahlnaden
Copy link
Collaborator

So the info icon was updated and I assumed this would be a global change
@rablador was this not an asset swap across the entire app? Or perhaps that's not reflected in main yet?

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not of main yet, but it will be there when my PR is merged.

@rablador reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@waahlnaden
Copy link
Collaborator

Screenshot 2026-02-18 at 09 51 17 This still says enable notifications when it should say open system settings

@waahlnaden
Copy link
Collaborator

Also, the link to system settings just sends me to the root of settings in iOS. It should still go directly to the notification part of the Mullvad VPN app.
Screenshot 2026-02-18 at 09 52 57

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right.

@rablador made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@mojganii mojganii force-pushed the fix-on-boarding-leftover-issues-iOS branch 2 times, most recently from 079e34b to bde473a Compare February 18, 2026 10:09
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did look at the code and the notification settings should be opened when pressing that button. When testing it doesn't work for some reason.

@rablador reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to not work on sim, but fine on phone.

@rablador made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@mojganii mojganii force-pushed the fix-on-boarding-leftover-issues-iOS branch from bde473a to de527e3 Compare February 19, 2026 08:53
@waahlnaden
Copy link
Collaborator

It's good

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@mojganii mojganii force-pushed the fix-on-boarding-leftover-issues-iOS branch from de527e3 to 8e0dfb9 Compare February 19, 2026 10:09
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@rablador rablador merged commit 6700a5b into main Feb 19, 2026
14 checks passed
@rablador rablador deleted the fix-on-boarding-leftover-issues-iOS branch February 19, 2026 12:16
@github-actions
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iOS Issues related to iOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants