Conversation
e08eb07 to
249a571
Compare
MarkusPettersson98
left a comment
There was a problem hiding this comment.
@MarkusPettersson98 reviewed 6 files and all commit messages, and made 5 comments.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on hulthe).
test/test-manager/src/vm/network/macos.rs line 9 at r1 (raw file):
}, unistd::Pid, };
👋
Code quote:
use nix::{
sys::{
signal::{Signal, kill},
socket::SockaddrStorage,
},
unistd::Pid,
};test/test-manager/Cargo.toml line 11 at r1 (raw file):
[dependencies] anyhow = { version = "1", features = ["backtrace"] } async-tempfile = "0.2"
This is unused on macOS now, right?
Code quote:
async-tempfile = "0.2"test/test-manager/src/vm/network/macos.rs line 87 at r1 (raw file):
} async fn create_wireguard_interface() -> Result<Device<DefaultDeviceTransports>> {
hell yeah
Code quote:
async fn create_wireguard_interface() -> Result<Device<DefaultDeviceTransports>>test/test-manager/src/vm/network/macos.rs line 110 at r1 (raw file):
} pub async fn configure_tunnel() -> Result<()> {
hell. yeah.
Code quote:
pub async fn configure_tunnel() -> Result<()>test/test-manager/src/main.rs line 455 at r1 (raw file):
log::info!("Root privileges required. Re-launching with sudo."); eprintln!("{cmd:?}");
Seems like a leftover from development? Remove before merge
Code quote:
eprintln!("{cmd:?}");d08384e to
ab148a0
Compare
ab148a0 to
bd49631
Compare
MarkusPettersson98
left a comment
There was a problem hiding this comment.
@MarkusPettersson98 reviewed 5 files and all commit messages, made 1 comment, and resolved 5 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved.
0d0f99c to
ea13202
Compare
49df6b1 to
47c5a5a
Compare
e01b017 to
d0ecfcc
Compare
d0ecfcc to
2adbe66
Compare
tobias-jarvelov
left a comment
There was a problem hiding this comment.
@tobias-jarvelov reviewed 2 files and made 1 comment.
Reviewable status: 5 of 9 files reviewed, all discussions resolved (waiting on MarkusPettersson98).
MarkusPettersson98
left a comment
There was a problem hiding this comment.
@MarkusPettersson98 reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved.
Unfortunately, creating a TUN device requires the test-manager to run as root, since macOS has nothing like setcap in Linux. I implemented this by the `test-manager` sudoing itself if it's not invoked as root. We did already require passwordless sudo on the test server for the same reason (creating the tun device using wireguard-go), so this is fine.
2adbe66 to
892cb68
Compare
This change is