Update buildserver build files and gradle to use new hardware key#9983
Draft
Update buildserver build files and gradle to use new hardware key#9983
Conversation
Pururun
force-pushed
the
sign-the-app-with-hardware-token-droid-1737
branch
4 times, most recently
from
ee5bcf9 to
0d00c8c
Compare
Pururun
force-pushed
the
sign-the-app-with-hardware-token-droid-1737
branch
2 times, most recently
from
9e73456 to
c6fe15a
Compare
Pururun
force-pushed
the
sign-the-app-with-hardware-token-droid-1737
branch
from
c6fe15a to
7d05d51
Compare
Contributor
albin-mullvad
left a comment
albin-mullvad
left a comment
There was a problem hiding this comment.
@albin-mullvad partially reviewed 4 files and made 2 comments.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on Pururun).
android/build.sh line 56 at r1 (raw file):
if [[ "$GRADLE_BUILD_TYPE" == "release" ]]; then assert_clean_working_directory
We still want to assert a clean work dir
ci/buildserver-build-android.sh line 41 at r1 (raw file):
CARGO_TARGET_VOLUME_NAME="cargo-target-android" \ CARGO_REGISTRY_VOLUME_NAME="cargo-registry-android" \ ./building/containerized-build.sh android --app-bundle --enable-play-publishing || return 1
Time to remove this option from build.sh if we no longer need it here maybe?
Code quote:
--enable-play-publishing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is