chore: Fill in todos #172
Open
chore: Fill in todos #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dustin4444
approved these changes
Jun 6, 2025
achingbrain
reviewed
Jun 6, 2025
achingbrain
reviewed
Jun 6, 2025
|
|
||
|
|
||
| ### Encoding | ||
| ### Encoding (Bytes -> String) |
There was a problem hiding this comment.
I know this has been in the spec for like, ever, but is this the right way round? IPLD generally refers to "encoding" as turning an object (string, here) into bytes and "decoding" as getting an object from bytes.
There was a problem hiding this comment.
wdyt about String Encoding instead?
There was a problem hiding this comment.
I think it has the same problem since "encoding" is still in the title.
This README was written a long time ago and the ecosystem has coalesced around certain language and conventions since then, I think we should bring this in line with everything else.
Co-authored-by: Alex Potsides <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unglamarous. Just filling in the missing details of encoding/decoding
Before Merge