Skip to content

Docs updates #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 6, 2025
Merged

Docs updates #76

merged 13 commits into from
Jul 6, 2025

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Jul 5, 2025

Docs dependencies were pinned too low and bumpversion is deprecated for bump-my-version.

Closes #71

Actions Taken

  • Removed upper pins for Sphinx and coverage
  • Replaced bumpversion with bump-my-version, moved config from bumpversion.cfg to pyproject.toml.
  • Added towncrier dependency + config, added newsfragment folder + newsfragments for recent PRs.
  • Remove calling setup.py to build, added build dependency and use that instead.
  • Merged test dependencies into dev.
  • aiodns dependency was unused, removed it, but required dnspython was not in dependencies, added it.

@pacrob
Copy link
Contributor Author

pacrob commented Jul 5, 2025

@acul - noticed resolver tests would not run. It looks like you were using the dnspython library instead of the aiodns one that was in dependencies. I've replaced it in this PR, but could you clarify what you meant to do?

I've also added towncrier and newsfragments, summarizing from your recent PRs. Please check what I've added to make sure you agree with what I've written. Thanks!

@acul71
Copy link
Contributor

acul71 commented Jul 6, 2025

dnspython library instead of the aiodns

Fantastic work @pacrob, thanks
I think I've added manually dnspython and forgot to update dependencies file.
Thanks for fixing that and add all the newsfragments.
Can be merged.
PS: Is in this repo Cl for running tests ? #69

@acul71 acul71 closed this Jul 6, 2025
@acul71 acul71 reopened this Jul 6, 2025
@acul71 acul71 marked this pull request as ready for review July 6, 2025 10:43
@acul71 acul71 merged commit e36af28 into multiformats:master Jul 6, 2025
@pacrob pacrob deleted the docs-updates branch July 9, 2025 19:27
@pacrob
Copy link
Contributor Author

pacrob commented Jul 9, 2025

Is in this repo Cl for running tests ? #69

I think yes, I aim to pick that up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev bug: make docs fails
2 participants