Skip to content

Conversation

@lla-dane
Copy link
Contributor

Tracks multiformats/multiaddr#181

Added the memory codec in py-multiaddr in reference with go-multiaddr implementation of memory:
https://github.com/multiformats/go-multiaddr/blob/b2ad16d978ea6b0f2cc49d20da2c0db24c92063d/transcoders.go#L493C1-L520C2

Protocol(P_P2P_CIRCUIT, "p2p-circuit", None),
Protocol(P_WEBTRANSPORT, "webtransport", None),
Protocol(P_UNIX, "unix", "fspath"),
Protocol(P_MEMORY, "memory", None)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what to write in the codec part here (so temporarily went with None), please clarify the correct parameter.

@lla-dane
Copy link
Contributor Author

lla-dane commented Sep 12, 2025

@seetadev @pacrob @acul71: Tried to add the memory protocol from go-multiaddr implemented here: https://github.com/multiformats/go-multiaddr/blob/b2ad16d978ea6b0f2cc49d20da2c0db24c92063d/transcoders.go#L493C1-L520C2.

Not sure if its correctly done, please provide feedback.

@seetadev
Copy link
Contributor

@lla-dane : Nice attempt, Abhinav. Appreciate your efforts.

Wish if you could fix CI/Cd issues today and re-share an update. I will run the CI/CD pipeline again.

@acul71 : Wish if you could share an initial feedback on @lla-dane's PR while @pacrob is working on the py-multiaddr release at pypi. I have shared all the missing protocols that need to be added in py-multiaddr with @lla-dane. He will work with you systematically on getting all the missing protocols available in py-multiaddr.

@acul71
Copy link
Contributor

acul71 commented Sep 13, 2025

@lla-dane : Nice attempt, Abhinav. Appreciate your efforts.

Wish if you could fix CI/Cd issues today and re-share an update. I will run the CI/CD pipeline again.

@acul71 : Wish if you could share an initial feedback on @lla-dane's PR while @pacrob is working on the py-multiaddr release at pypi. I have shared all the missing protocols that need to be added in py-multiaddr with @lla-dane. He will work with you systematically on getting all the missing protocols available in py-multiaddr.

I was thinking that it's better to work on new_install branch because new tools have been added for lint etc.
@lla-dane can you try to resolve the issues on that branch?
ping me if you need help

@lla-dane lla-dane closed this Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants