add minimum kubebuilder manifests to get "make install" working#31
Merged
add minimum kubebuilder manifests to get "make install" working#31
Conversation
rytswd
approved these changes
Oct 14, 2025
Contributor
rytswd
left a comment
rytswd
left a comment
There was a problem hiding this comment.
Thanks LGTM! I was ok adding these at any point, but wanted to keep them out from the CRD setup for easier review
rcambrj
force-pushed
the
fix-make-install
branch
from
a351bfc to
455c714
Compare
rcambrj
force-pushed
the
fix-make-install
branch
from
455c714 to
af1b0f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make installmake run(like fix "make run" #25, but now the reconcile loop doesn't error due to missing CRDs)I suspect that we can trim a bunch of these manifests down at some point.