feat(operator): wire backup retention, health, and metrics#449
Draft
Verolop wants to merge 9 commits intomultigres:mainfrom
Draft
feat(operator): wire backup retention, health, and metrics#449Verolop wants to merge 9 commits intomultigres:mainfrom
Verolop wants to merge 9 commits intomultigres:mainfrom
Conversation
- add retention fields to the backup API and default them through the resolver - extend backup health evaluation with integrity and retention checks - register backup lifecycle metrics and regenerate CRD and deepcopy artifacts Signed-off-by: Veronica Lopez <veronica.lopez@supabase.io>
Verolop
force-pushed
the
feat/s3-backup-lifecycle
branch
from
31a3b69 to
ef16d8d
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Add focused tests for retention merge and defaulting, extended backup health evaluation, and repository health condition handling. Signed-off-by: Veronica Lopez <veronica.lopez@supabase.io>
Verolop
force-pushed
the
feat/s3-backup-lifecycle
branch
from
d83b81b to
71b5499
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Veronica Lopez <veronica.lopez@supabase.io>
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Veronica Lopez <veronica.lopez@supabase.io>
Verolop
force-pushed
the
feat/s3-backup-lifecycle
branch
from
a65858a to
c3f6cf9
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Veronica Lopez <veronica.lopez@supabase.io>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Veronica Lopez <veronica.lopez@supabase.io>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Veronica Lopez <veronica.lopez@supabase.io>
This comment has been minimized.
This comment has been minimized.
…aults Signed-off-by: Veronica Lopez <veronica.lopez@supabase.io>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Veronica Lopez <veronica.lopez@supabase.io>
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds the operator-side retention, health evaluation, and observability pieces for the first backup lifecycle slice.
It introduces declarative retention settings on the backup API, applies retention defaults in the resolver, extends backup health evaluation with integrity and retention signals, and registers initial backup lifecycle metrics. These changes are designed to consume backup state reported by the data plane rather than reimplement backup state inside the operator.
Changes
cleanupOnDeleteandallowStaleMetadataRecoveryfor S3 backupsValidation
Regenerated deepcopy code and CRD manifests, then verified that the generated output matched the API changes and that the health and metrics changes stayed scoped to the operator-side backup lifecycle work.
Related Issues
This PR is paired with the Multipooler-side backup state reporting changes in multigres#811. Together, the two PRs establish the first operator/data-plane slice for retention-aware backup health evaluation, integrity reporting, and lifecycle observability.