Conversation
rytswd
left a comment
There was a problem hiding this comment.
The key logic makes sense and LGTM, just left a comment about the version sha
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 |
There was a problem hiding this comment.
I think it is common to use a version tag than commit sha with GitHub Actions, but I'm fine with this. We'd need a quick script or some logic to update this though
There was a problem hiding this comment.
I came across this approach while researching these code scanning tools, where I came saw code written by more security-conscious folk. The concern with tags, as usual, is that they can change. You would normally have a lockfile with a hash for dependencies, but in the case of github workflows there is none. This is the next best thing.
I accept that it's a bit janky and appreciate that this requires some flexibility from developers' POV, and I agree that an updater tool would be great.
scans dependencies with
actions/dependency-review-action(only during pull request workflow, and only scans new dependencies) - this is what it looks likescans all code (including Go, but I suspect excluding nix) with
github/codeql-action- this is what it looks likescans the built container image with
anchore/scan-action(a wrapper aroundgrype) - this is what it looks likeand locks all
uses:to a fixed commit hash whilst retaining a human-friendly reference to the version in a commentBits I don't like (could be improved later)
vulnixexists there is no github action that I could find, and given that nix plays only a devshell role, I figured we could tackle this another day.grypecontainer image scanner requires that the container image be uploaded (pushed) and then downloaded (pulled) before scanning. For this reason, the container image gets pushed even when the workflow's inputpush-container-imageisfalse- only thelatestand tag versions get pushed whenpush-container-imageis true.