Fix undefined behavior in server CElement::CallEventNoParent

Dutchman101 · Dutchman101 · commit d14f4906993d · 2025-08-13T06:01:39.000+08:00
diff --git a/Server/mods/deathmatch/logic/CElement.cpp b/Server/mods/deathmatch/logic/CElement.cpp
@@ -1019,7 +1019,8 @@ void CElement::CallEventNoParent(const char* szName, const CLuaArguments& Argume
     }
 
     // Call it on all our children
-    for (CElement* pElement : *GetChildrenListSnapshot())
+    auto* childrenList = GetChildrenListSnapshot();
+	for (CElement* pElement : *childrenList)
     {
         if (!pElement->IsBeingDeleted())
         {

Original file line number	Diff line number	Diff line change
`@@ -1019,7 +1019,8 @@ void CElement::CallEventNoParent(const char* szName, const CLuaArguments& Argume`
`1019`	`1019`	`}`
`1020`	`1020`
`1021`	`1021`	`// Call it on all our children`
`1022`		`- for (CElement* pElement : *GetChildrenListSnapshot())`
	`1022`	`+ auto* childrenList = GetChildrenListSnapshot();`
	`1023`	`+ for (CElement* pElement : *childrenList)`
`1023`	`1024`	`{`
`1024`	`1025`	`if (!pElement->IsBeingDeleted())`
`1025`	`1026`	`{`