Skip to content

Fix #2932 (Fix CEF hardware acceleration not working) #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2024
Merged

Fix #2932 (Fix CEF hardware acceleration not working) #2933

merged 3 commits into from
Oct 8, 2024

Conversation

@TFP-dev
Copy link
Contributor

@TFP-dev TFP-dev commented Mar 24, 2023

Fixes #2932 and fixes WebGL not working.

Current MTA:
https://youtu.be/Mca4FgfQqMo

Fixed:
https://youtu.be/tepQ-iWNKIM

No issues found, browser works as smooth as it was before this fix (but WebGL is now working)

@patrikjuvonen
Copy link
Contributor

patrikjuvonen commented Mar 25, 2023

It has been disabled for security reasons.

@TFP-dev
Copy link
Contributor Author

TFP-dev commented Mar 25, 2023

It has been disabled for security reasons.

Why? RAGE Multiplayer have it enabled in their CEF and I can't see any "security reasons" why it should be disabled in MTA.

@AlexTMjugador
Copy link
Member

AlexTMjugador commented Mar 25, 2023

@Lpsd mentioned some other reasons why GPU acceleration is disabled on MTA's CEF implementation on Discord:

Discord message

@lopezloo lopezloo added the bug Something isn't working label Apr 4, 2023
@Xenius97 Xenius97 mentioned this pull request Oct 4, 2024
Closed
1 task
@Pirulax
Copy link
Contributor

Pirulax commented Oct 8, 2024

Okay, so merging this would be nice.
We just have to investigate the abovementioned "security reasons" associated with it.

@Pirulax Pirulax reopened this Oct 8, 2024
TheNormalnij
TheNormalnij reviewed Oct 8, 2024
View reviewed changes
Lpsd
Lpsd requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Lpsd Lpsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we discussed this in #ask-developers on Discord and believe the security issues are no longer a concern.

Worth removing the disable-gpu-compositing flag too as this will improve performance.

All changes in this PR should be excluded from the maetro release (W7/8).

Lpsd and others added 2 commits October 8, 2024 18:34
@Lpsd Lpsd merged commit 0263011 into multitheftauto:master Oct 8, 2024
6 checks passed
MTABot pushed a commit that referenced this pull request Oct 8, 2024
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
d4ef823 
0263011 Fix #2932 (Fix CEF hardware acceleration not working) (#2933)
@Lpsd Lpsd mentioned this pull request Oct 19, 2024
Merged
@PlatinMTA PlatinMTA mentioned this pull request Nov 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pirulax Pirulax Pirulax left review comments

@Lpsd Lpsd Lpsd approved these changes

+1 more reviewer

@TheNormalnij TheNormalnij TheNormalnij left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CEF Vulkan errors

7 participants

@TFP-dev @patrikjuvonen @AlexTMjugador @Pirulax @TheNormalnij @Lpsd @lopezloo