Skip to content

Add removeGameWorld and restoreGameWorld #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 10, 2025
Merged

Add removeGameWorld and restoreGameWorld #3627

merged 13 commits into from
Jan 10, 2025

Conversation

@TheNormalnij
Copy link
Member

@TheNormalnij TheNormalnij commented Aug 2, 2024

Fixes #3607
removeAllGameBuildings cleans only buildings pool and leaves rare dynamic elements in the game world.
removeGameWorld fixes that issue by cleaning the dummies pool too.

-- Removes all buildings and dummies from game world and frees both pools
nil removeGameWorld()

-- Restores all buildings and dummies
nil restoreGameWorld()

removeAllGameBuildings and restoreAllGameBuildings will be deprecated and removed in future releases

@TheNormalnij TheNormalnij added enhancement New feature or request bugfix Solution to a bug of any kind labels Aug 2, 2024
@TheNormalnij TheNormalnij added this to the 1.6.1 milestone Aug 2, 2024
TracerDS
TracerDS suggested changes Aug 2, 2024
View reviewed changes
@TheNormalnij TheNormalnij marked this pull request as ready for review August 4, 2024 17:07
TracerDS
TracerDS suggested changes Aug 21, 2024
View reviewed changes
@Fernando-A-Rocha
Copy link
Contributor

Fernando-A-Rocha commented Oct 15, 2024

@TheNormalnij will u please update the wiki? Let me know if u need advice

@TheNormalnij
Copy link
Member Author

TheNormalnij commented Oct 15, 2024

@TheNormalnij will u please update the wiki? Let me know if u need advice

Yep

Fernando-A-Rocha

This comment was marked as outdated.

Sign in to view

botder
botder requested changes Dec 30, 2024
View reviewed changes
@botder botder merged commit d7adae6 into multitheftauto:master Jan 10, 2025
6 checks passed
MTABot pushed a commit that referenced this pull request Jan 10, 2025
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
33f8841 
d7adae6 Add removeGameWorld and restoreGameWorld (PR #3627, Fixes #3607)
@TheNormalnij TheNormalnij deleted the TheNormalnij/removeAllWorld branch January 29, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dutchman101 Dutchman101 Dutchman101 left review comments

@botder botder botder approved these changes

+2 more reviewers

@TracerDS TracerDS TracerDS requested changes

@Fernando-A-Rocha Fernando-A-Rocha Fernando-A-Rocha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix Solution to a bug of any kind enhancement New feature or request

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

removeAllGameBuildings doesn't remove the whole map

5 participants

@TheNormalnij @Fernando-A-Rocha @Dutchman101 @botder @TracerDS