Improve random nick generation

[Lpsd]

Fixes issue from #3777 where nickname parts could be "null" due to not updating the constants (which are now removed in place of better code).

[TracerDS]

maybe add the random function to SharedUtils (SharedUtil.random.hpp?) and from there you can call that function in the nick generation func?

[shadylua]

like :

#ifndef SHARED_UTIL_RANDOM_HPP
#define SHARED_UTIL_RANDOM_HPP

#include <random>

namespace SharedUtil {
    inline int RandomInt(int min, int max) {
        static std::random_device rd;
        static std::mt19937 gen(rd());
        std::uniform_int_distribution<int> dist(min, max);
        return dist(gen);
    }
}

#endif // SHARED_UTIL_RANDOM_HPP

[Lpsd]

You don't want to create a new generator for each part of the nickname. In-fact, we should probably share the generator between successive calls.

[TracerDS]

Possibly a template there with pragma and optimized code but yeah, something like that

[TracerDS]

You don't want to create a new generator for each part of the nickname. In-fact, we should probably share the generator between successive calls.

We can have a static (maybe const) generator that will be shared with related functions only.
That way it will not be generated again and the overhead would be minimal