Fast Fix for #3900 2 #3921
Merged
Fast Fix for #3900 2 #3921
+153
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileEX
reviewed
Jan 2, 2025
Member
FileEX
left a comment
FileEX
left a comment
There was a problem hiding this comment.
Since you're already on it, wouldn't it be better to rewrite this function using the new parser? It would definitely be more readable
Contributor
Author
I was asked to fix this, I don't really understand the new style of lua functions, but I'll try. |
Contributor
Author
Most likely, it is better to do this in a separate PR, since I was asked to make these changes. |
Member
|
What does exactly this fixes? Or it's a refactor? |
Contributor
Author
GetHandlingData essentially cannot produce a nullptr |
botder
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.