Fix wrong function deprecated warnings with variables (Issue #1435) #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YelehaUwU
changed the title
Fernando-A-Rocha
approved these changes
Jan 5, 2025
Contributor
Fernando-A-Rocha
left a comment
Fernando-A-Rocha
left a comment
There was a problem hiding this comment.
Without this PR, banIP = "192.168.1.69" will produce a warning.
I confirm that with these changes, this code no longer produces a warning.
GJ 👍
YelehaUwU
changed the title
YelehaUwU
changed the title
TheNormalnij
reviewed
Jan 5, 2025
TheNormalnij
reviewed
Jan 5, 2025
Contributor
Author
|
|
tederis
reviewed
Jan 6, 2025
tederis
reviewed
Jan 6, 2025
Contributor
Author
|
All changes needed done. |
Contributor
Author
|
Can this get merged now? |
FileEX
approved these changes
Mar 1, 2025
Member
|
Thanks for the patch, and implementing all code reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue #1435 and fixes the issue by implementing context around the scanned name, ignoring variables.
It is fully tested on a locally hosted server and works fine.