Skip to content

Add download progress handler for CEF in premake #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Add download progress handler for CEF in premake #3988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53e9205
Add download progress handler for CEF in premake
TheNormalnij Jan 29, 2025
1217eaf
tabs and spaces
TheNormalnij Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/buildactions/install_cef.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ newaction {
else
-- Download CEF
print("Downloading CEF " .. CEF_VERSION .. "...")
if not http.download_print_errors(make_cef_download_url(), archive_path) then
if not http.download_print_errors(make_cef_download_url(), archive_path, { progress = http.create_download_progress_handler{update_interval_s = 5} }) then
os.exit(1)
return
end
Expand Down
18 changes: 18 additions & 0 deletions utils/buildactions/utils.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,24 @@ function os.extract_archive(archive_path, target_path, override)
return false
end

function http.create_download_progress_handler(options)
local last_update = 0

return function (total, current)
local tick = os.clock()
if tick - last_update < options.update_interval_s then
return
end

last_update = tick

local ratio = current / total;
ratio = math.min(math.max(ratio, 0), 1)
local percent = math.floor(ratio * 100)
print(string.format("Downloading (%d/%d) %d%%", current, total, percent))
end
end

function http.download_print_errors(url, file, options)
local result_str, response_code = http.download(url, file, options)
if result_str ~= "OK" then
Expand Down
Loading