Skip to content

Conversation

@G-Moris
Copy link
Contributor

@G-Moris G-Moris commented Feb 18, 2025

No description provided.

Copy link
Member

@botder botder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module gets created/loaded in CCore constructor

@botder botder merged commit 8fa45f1 into multitheftauto:master Feb 18, 2025
6 checks passed
@botder botder added this to the 1.6.1 milestone Feb 18, 2025
MTABot pushed a commit that referenced this pull request Feb 18, 2025
8fa45f1 Refactor repeated uses of CCore::CreateXML (PR #4033)
a6c7300 Update client en_US pot
botder added a commit that referenced this pull request Feb 19, 2025
MTABot pushed a commit that referenced this pull request Feb 19, 2025
2b6ecd0 Revert "Refactor repeated uses of CCore::CreateXML (PR #4033)"
@botder
Copy link
Member

botder commented Feb 19, 2025

This had to be reverted because key bindings were not loading properly and were missing.

@Lpsd
Copy link
Member

Lpsd commented Feb 19, 2025

https://github.com/multitheftauto/mtasa-blue/blob/master/Client/core/CCore.cpp#L95

Move this line below the m_pKeyBinds instantiation if you want to remove the other CreateXML calls.

Alternatively, and probably a better solution to fix this spaghetti code, is to move the following logic to its own function and call it after the m_pKeyBinds instantiation, leaving the CreateXML call where it is. Maybe that logic can even go in the CKeyBinds constructor....

https://github.com/multitheftauto/mtasa-blue/blob/master/Client/core/CCore.cpp#L1079-L1084

Please test your work before submitting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants