-
-
Notifications
You must be signed in to change notification settings - Fork 501
Fix killPedTask crash #4045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix killPedTask crash #4045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve this using the suggestion in the previous review. There is a reason the MAX entries are defined in the enum (also the reason why I made that suggestion).
Whilst it's unlikely the enum will change, if new entries are added then your code would be faulty and need updating. We would rather avoid that entirely (making less work for future contributors), which is why you compare to the MAX enum entry for such range checks.
done |
|
Looks good now, thanks! |
Add validation
#4039