Refactor CWeaponSA class #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Dutchman101 merged 5 commits into multitheftauto:master from FileEX:refactor/CWeaponSA

Mar 1, 2025

Member

FileEX commented Feb 21, 2025

Refactoring of CWeaponSA.cpp, CWeaponSA.h, and CWeapon.h according to the latest coding guidelines and C++ standards
Cleanup of the aforementioned files
Completion of missing fields in the CWeaponSAInterface class and cleanup of their types

FileEX added 2 commits

February 21, 2025 19:15


          Refactor

80be6cf


          Remove includes

ea190e5

G-Moris reviewed

View reviewed changes

Client/game_sa/CWeaponSA.cpp Outdated Show resolved Hide resolved


          Review

5273a2d

G-Moris reviewed

View reviewed changes

Client/game_sa/CWeaponSA.h Show resolved Hide resolved


          Review

b669503

TheNormalnij reviewed

View reviewed changes

Client/game_sa/CWeaponSA.cpp Show resolved Hide resolved

TheNormalnij reviewed

View reviewed changes

Client/game_sa/CWeaponSA.cpp Show resolved Hide resolved

TheNormalnij reviewed

View reviewed changes

Client/game_sa/CWeaponSA.cpp Show resolved Hide resolved

TheNormalnij reviewed

View reviewed changes

Client/game_sa/CWeaponSA.h Show resolved Hide resolved

TheNormalnij reviewed

View reviewed changes

Client/game_sa/CWeaponSA.cpp Show resolved Hide resolved


          Merge branch 'master' into refactor/CWeaponSA

1b0cfaa

Dutchman101 merged commit a3b7c85 into multitheftauto:master

6 checks passed

MTABot pushed a commit that referenced this pull request


          Synchronize changes from 1.6 master branch [ci skip]

8c47b29

a3b7c85 Refactor CWeaponSA class (#4048)
468ea70 New Crowdin updates (PR #4054)
e4aba7c Visual Studio Update
cad5e08 Update client en_US pot

botder added this to the 1.6.1 milestone

botder added the refactor label

FileEX deleted the refactor/CWeaponSA branch

March 2, 2025 12:57

Member

TheNormalnij commented Mar 2, 2025

This PR needs a refactor. In this state it creates more problems than it solves

FileEX restored the refactor/CWeaponSA branch

March 3, 2025 07:24

FileEX mentioned this pull request

Fix custom weapon issue #4072 #4076

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels