Skip to content

Fix crash caused by #3725 in CChat::CharacterKeyHandler #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Fix crash caused by #3725 in CChat::CharacterKeyHandler #4060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions Client/core/CChat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,13 +660,14 @@ bool CChat::CharacterKeyHandler(CGUIKeyEventArgs KeyboardArgs)
{
// If the input is a command, check that it isn't the 'login' command, if it is censor it
char szInput[256];
strncpy(szInput, m_strInputText.c_str() + 1, 256);
unsigned int uiLength = sizeof(szInput) - 1;

const char* szCommand;
if (szInput[0])
szCommand = strtok(szInput, " ");
strncpy(szInput, m_strInputText.c_str() + 1, uiLength);
szInput[uiLength] = '\0';

if ((strcmp(szCommand, "login") != 0))
const char* szCommand = strtok(szInput, " ");

if (szCommand && (strcmp(szCommand, "login") != 0))
m_pInputHistory->Add(m_strInputText);
else if ((m_pInputHistory->Empty() || m_pInputHistory->GetLast() != std::string("/login")))
m_pInputHistory->Add("/login");
Expand Down
Loading