Skip to content

Conversation

@tederis
Copy link
Member

@tederis tederis commented May 7, 2025

Fixes a crash and interior disappearing when throwing granades inside interiors.

@tederis tederis added the bugfix Solution to a bug of any kind label May 7, 2025
@tederis tederis changed the title Crash fix introduced by #4187 Fix introduced by #4187 issues May 7, 2025
@tederis tederis mentioned this pull request May 7, 2025
@Dutchman101
Copy link
Member

Note: subject is game_sa.dll crash at offset 0x00012AE8 (Bug report #4202 - also see comment)

We were collaborating on investigating it (me, FileEX and TEDERIs) so PR #4208 and #4206 are a conclusive fix.

What was happening is that the whole interior object breaking on explosions like a grenade, the main bug, caused the interior's LOD (going through pLODInterface) to be nullptr as player was streaming out of it when they fell into the sky (interior-less) or died.

As it turned out, the actual reason was related to introduced by #4208 issues. And there's the dedicated PR #4208. But the current PR is still viable as it prevents from potential problems in future.

Yes. As generally speaking, pLODInterface can be nullptr, and even GTA’s own code checks for that—but CBuildingRemovalSA didn’t up until now with PR #4206.

Both PR #4206 and #4208 will be merged now at the same time, so the whole situation is resolved. Thanks for the help!

@Dutchman101 Dutchman101 changed the title Fix introduced by #4187 issues Fix interiors bug introduced by #4187 May 7, 2025
@Dutchman101 Dutchman101 merged commit 2c70978 into multitheftauto:master May 7, 2025
6 checks passed
MTABot pushed a commit that referenced this pull request May 7, 2025
@Dutchman101 Dutchman101 mentioned this pull request May 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Solution to a bug of any kind

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants