Potential fix for #4209 #4218
Merged
Potential fix for #4209 #4218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botder
approved these changes
May 10, 2025
1 task
huncrys
added a commit
to huncrys/mtasa-blue
that referenced
this pull request
May 31, 2025
…ultitheftauto#4209)" This reverts commit 9084552.
huncrys
added a commit
to huncrys/mtasa-blue
that referenced
this pull request
Jun 23, 2025
…ultitheftauto#4209)" This reverts commit 9084552.
huncrys
added a commit
to huncrys/mtasa-blue
that referenced
this pull request
Jul 8, 2025
…ultitheftauto#4209)" This reverts commit 9084552.
huncrys
added a commit
to huncrys/mtasa-blue
that referenced
this pull request
Jul 18, 2025
…ultitheftauto#4209)" This reverts commit 9084552.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue with string hash calculation that #4169 was brought. Lua relies on strings without a null terminator which had not been taken into account. This potentially can lead to non-uniform hashmap access which in turn leads to poor performance. Thanks to @samr46 for pointing it out.