Replace isPed/VehicleOnGround with isElementOnGround
#4575
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileEX
requested changes
Nov 27, 2025
FileEX
previously approved these changes
Nov 28, 2025
tederis
previously approved these changes
Dec 2, 2025
qaisjp
reviewed
Jan 7, 2026
| return CStaticFunctionDefinitions::SetElementOnFire(element, onFire); | ||
| } | ||
|
|
||
| bool CLuaElementDefs::IsElementOnGround(CElement* element) |
Member
There was a problem hiding this comment.
Did you try this?
Suggested change
| bool CLuaElementDefs::IsElementOnGround(CElement* element) | |
| bool CLuaElementDefs::IsElementOnGround(std::variant<CPlayer*, CPed*, CVehicle*> element) |
This would allow ArgumentParser to natively handle the invalid argument case. (You'd need to change the implementation slightly though, signature change is not enough.)
Contributor
Author
There was a problem hiding this comment.
Didn't know about this, ty.
Updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2650
Old methods got deprecated, but still working.
isElementOnGroundcombines bothisPedOnGround&&isVehicleOnGround