Rotor speed/state synchronisation #4594
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xenius97
changed the title
FileEX
requested changes
Dec 6, 2025
This reverts commit d806c51.
FileEX
requested changes
Dec 7, 2025
Server/mods/deathmatch/logic/packets/CVehiclePuresyncPacket.cpp
Outdated
Show resolved
Hide resolved
Server/mods/deathmatch/logic/packets/CVehiclePuresyncPacket.cpp
Outdated
Show resolved
Hide resolved
FileEX
requested changes
Dec 7, 2025
Server/mods/deathmatch/logic/packets/CVehiclePuresyncPacket.cpp
Outdated
Show resolved
Hide resolved
Server/mods/deathmatch/logic/packets/CVehiclePuresyncPacket.cpp
Outdated
Show resolved
Hide resolved
This reverts commit 9ce8f22.
Member
|
uh, just wanted to try reopening this, but apparently I'm not able to reopen. @Xenius97 are you able to reopen this? |
Contributor
Author
doesn't allow for me, but maybe i can open a new pr |
Contributor
Author
|
@sbx320 can u try to reopen? now fork is fixed, but doesn't let me maybe because u closed |
Contributor
Author
|
thanks! |
FileEX
reviewed
Jan 6, 2026
qaisjp
reviewed
Jan 7, 2026
Comment on lines
3074
to
3096
| float CLuaVehicleDefs::GetVehicleRotorSpeed(CVehicle* pVehicle) | ||
| { | ||
| float rotorSpeed = 0.0f; | ||
| CStaticFunctionDefinitions::GetVehicleRotorSpeed(pVehicle, rotorSpeed); | ||
| return rotorSpeed; | ||
| } | ||
|
|
||
| bool CLuaVehicleDefs::SetVehicleRotorSpeed(CElement* pElement, float rotorSpeed) | ||
| { | ||
| return CStaticFunctionDefinitions::SetVehicleRotorSpeed(pElement, rotorSpeed); | ||
| } | ||
|
|
||
| bool CLuaVehicleDefs::GetVehicleRotorState(CVehicle* pVehicle) | ||
| { | ||
| bool rotorState = false; | ||
| CStaticFunctionDefinitions::GetVehicleRotorState(pVehicle, rotorState); | ||
| return rotorState; | ||
| } | ||
|
|
||
| bool CLuaVehicleDefs::SetVehicleRotorState(CElement* pElement, bool rotorState, std::optional<bool> stopRotor) | ||
| { | ||
| return CStaticFunctionDefinitions::SetVehicleRotorState(pElement, rotorState, stopRotor); | ||
| } |
Member
There was a problem hiding this comment.
Non-blocking but please could you merge the CStaticFunctionDefinitions into CLuaVehicleDefs? The static function definitions exist mostly for legacy reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces rotor speed synchronisation, which was already existing in code but looks it was unfinished (RPC was registered but nothing happened)
Now this is fully functional, rotor speed is synced between clients and added new server side get/set functions.
setVehicleRotorSpeedandgetVehicleRotorSpeedare now sharedsetVehicleRotorStateandgetVehicleRotorStateare shared toogta_sa_nA1tn2LGue.mp4