-
-
Notifications
You must be signed in to change notification settings - Fork 529
Bump LunaSVG to 0dd60d1 #4615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump LunaSVG to 0dd60d1 #4615
Conversation
Lua API: svgRegisterFont(string fontFamily, string path) svgUnregisterFont(string fontFamily)
|
|
|
Since these are conceptually different changes, please could we move the custom resource font support to a separate pull request? (you could maybe, optionally, stack it on top of this pull request) |
This reverts commit 969dfec.
qaisjp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Maybe we should wait until 1.7 releases before merging, since (presumably) 1.7 will release in the next couple of weeks? What do you think?
|
sounds fine, there is nothing urgent here as far as I'm aware. thanks! |
qaisjp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving since I wasn't in the blue contributors team (just added myself now)
…- PR #4615 See [releases for LunaSVG](https://github.com/sammycage/lunasvg/releases) for changes in previous versions. Testing resource with presets/test cases: [svg.zip](https://github.com/user-attachments/files/24606373/svg.zip) Additional PR for custom font support #4620
d70f8c8 1.6: Bump LunaSVG from 3.2.0 to [0dd60d1](sammycage/lunasvg@0dd60d1) - PR #4615
Bumps LunaSVG from 3.2.0 to 0dd60d1.
See releases for LunaSVG for changes in previous versions.
Testing resource with presets/test cases: svg.zip
Additional PR for custom font support #4620