Skip to content

Conversation

Nico8340
Copy link
Member

This pull request is intended to refactor the coding guidelines for mtasa-resources, firstly updating the structure of the document and adding examples to what was previously a one-liner. The additional content will arrive after this pull request is merged and discussed.

@TracerDS TracerDS self-assigned this Jul 11, 2024
Copy link
Contributor

@TracerDS TracerDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've missed some points like indentation and formatting, general principles but overall, good job.

@Fernando-A-Rocha
Copy link

Good job. Why did you remove the part which links to the Script Security article? @Nico8340

@Nico8340
Copy link
Member Author

Good job. Why did you remove the part which links to the Script Security article? @Nico8340

I'll add more details later, this is a very work in progress pull request, plus there are a lot of things that need to be clarified in the community before I even include them, these are just the most basic things.
I just need some time to get back to this pull request and the necessary communication and my other abandoned contributions, because I'm busy developing a private project for few days.

@Fernando-A-Rocha
Copy link

there are a lot of things that need to be clarified in the community before I even include them, these are just the most basic things

I agree. There needs to be input from the mtasa-resources maintainers.

@Fernando-A-Rocha Fernando-A-Rocha marked this pull request as draft July 23, 2024 11:31
@TracerDS TracerDS removed their assignment Aug 26, 2024
@Fernando-A-Rocha
Copy link

@Nico8340 #6 was merged. Do you still have ideas to alter the resources guidelines?

@Nico8340 Nico8340 closed this Oct 7, 2024
@Nico8340 Nico8340 deleted the resources branch October 7, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants