Skip to content

editor: Fix #142 #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 2, 2020
Merged

editor: Fix #142 #155

merged 8 commits into from
Nov 2, 2020

Conversation

FileEX
Copy link
Member

@FileEX FileEX commented Jun 13, 2019

Fixes #142
Now dimension is save correctly.

@qaisjp qaisjp added the bug label Jun 13, 2019
@patrikjuvonen patrikjuvonen changed the title Fix #142 editor: fix #142 Jun 14, 2019
@patrikjuvonen patrikjuvonen changed the title editor: fix #142 editor: Fix #142 Jun 14, 2019
@patrikjuvonen patrikjuvonen self-requested a review June 22, 2019 20:11
@qaisjp qaisjp changed the title editor: Fix #142 Fix #142 Jun 30, 2019
@qaisjp qaisjp changed the title Fix #142 editor: Fix #142 Jan 17, 2020
@patrikjuvonen patrikjuvonen added this to the 1.6 milestone Apr 1, 2020
patrikjuvonen
patrikjuvonen previously requested changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@patrikjuvonen patrikjuvonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this fix has the side-effect of elements set into other dimensions are forever hidden as map (editor) dimension cannot be changed.

This fix should instead only affect the save but not real-time.

@patrikjuvonen patrikjuvonen removed their assignment Apr 1, 2020
@patrikjuvonen patrikjuvonen removed this from the 1.6 milestone Apr 1, 2020
@FileEX
Copy link
Member Author

FileEX commented Jun 1, 2020

Fixed!

@jlillis jlillis dismissed patrikjuvonen’s stale review November 2, 2020 09:20

Requested changes addressed by author.

@jlillis
Copy link
Contributor

jlillis commented Nov 2, 2020

I've confirmed this PR works as intended and resolves #142 and #190

@jlillis jlillis merged commit a38d3cb into multitheftauto:master Nov 2, 2020
@jlillis jlillis mentioned this pull request Nov 2, 2020
Closed
@qaisjp qaisjp added this to the 1.6 milestone Nov 2, 2020
@patrikjuvonen patrikjuvonen modified the milestones: 1.6, 1.5.9 Apr 22, 2022
@FileEX FileEX deleted the bugfix-dim branch April 19, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@patrikjuvonen patrikjuvonen patrikjuvonen left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug resource:editor
Projects
None yet
Milestone
1.5.9
Development

Successfully merging this pull request may close these issues.

editor_main: save doesn't save element dimension
4 participants
@FileEX @jlillis @patrikjuvonen @qaisjp