admin2: replace give admin button with permissions widget #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork update
jlillis
requested changes
Nov 11, 2020
| messageBox("No group selected!", MB_WARNING) | ||
| else | ||
| local group = guiGridListGetItemText(aPermissions.List, guiGridListGetSelectedItem(aPermissions.List), 1) | ||
| if (messageBox('Are you sure to give "' .. group .. '"?', MB_QUESTION, MB_YESNO)) then |
There was a problem hiding this comment.
I think a better message would be "Are you sure you want to add [player] to the '[group name]' group?"
| messageBox("No group selected!", MB_WARNING) | ||
| else | ||
| local group = guiGridListGetItemText(aPermissions.List, guiGridListGetSelectedItem(aPermissions.List), 1) | ||
| if (messageBox('Are you sure to revoke "' .. group .. '"?', MB_QUESTION, MB_YESNO)) then |
There was a problem hiding this comment.
I think a better message would be "Are you sure you want to remove [player] from the '[group name]' group?"
| <log>ADMIN: $admin has revoked admin privilegies from $player</log> | ||
| <admin>$player's $data group have been revoked</admin> | ||
| <player>$admin has revoked your $data group</player> | ||
| <log>ADMIN: $admin has revoked $data group from $player</log> |
There was a problem hiding this comment.
Again, I think it would be better to say "[player] has been removed from the [group] group."
qaisjp
changed the title
|
if someone is going to finish this, it may be worth adding the changes added in #324 |
|
Going to close this PR as it has become stale. Feel free to reopen it in the future if you find time to address the above comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #107