Skip to content

Conversation

stoneage-mta
Copy link
Contributor

@stoneage-mta stoneage-mta commented Apr 11, 2021

After merged, this PR will add a filter to the following lists:

  • Slap!
  • Give weapon
  • Give Vehicle

Before:
image

After:
image

IMHO we don't need to add this to admin2, because their lists are a little bit different.

Copy link
Contributor

@Dezash Dezash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The min version in meta.xml needs to be bumped
image

It would also make sense to apply this feature to Skins and Weathers in Server tab.

@stoneage-mta
Copy link
Contributor Author

It would also make sense to apply this feature to Skins and Weathers in Server tab.

I am not sure if we really should add this to Skins and Weathers because they are not like the lists mentioned in this PR, I can change it too, but I think it fits better in another PR.

Skins selection:
image

Weather selection:
image

Copy link
Contributor

@Dezash Dezash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To close the list, I now have to press a button when previously I could just click somewhere else. I think this behavior should be retained.

@stoneage-mta
Copy link
Contributor Author

I think it's ready to review again.

Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would you consider making the same or similar additions to admin2? We're trying to reach feature parity between the two. I'm ready to merge this either way.

@stoneage-mta
Copy link
Contributor Author

stoneage-mta commented May 12, 2021

@jlillis, I can add such things to admin2, but afaik the lists are a little bit different in admin2.
Btw If you want, feel free to merge, I think this weekend I can take a look at admin2 and submit another PR.

@stoneage-mta
Copy link
Contributor Author

@jlillis, I can add such things to admin2, but afaik the lists are a little bit different in admin2.
Btw If you want, feel free to merge, I think this weekend I can take a look at admin2 and submit another PR.

resolved in #324.

@jlillis
Copy link
Contributor

jlillis commented Jun 7, 2021

Looks like there's a merge conflict blocking this - could you resolve?

@stoneage-mta
Copy link
Contributor Author

Looks like there's a merge conflict blocking this - could you resolve?

@jlillis done

@jlillis jlillis merged commit 4ae9f38 into multitheftauto:master Jun 7, 2021
@stoneage-mta stoneage-mta deleted the idz-extends-lists branch June 8, 2021 01:36
@patrikjuvonen patrikjuvonen added this to the 1.5.9 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants