-
-
Notifications
You must be signed in to change notification settings - Fork 171
admin: Improve lists #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: Improve lists #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we really should add this to Skins and Weathers because they are not like the lists mentioned in this PR, I can change it too, but I think it fits better in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To close the list, I now have to press a button when previously I could just click somewhere else. I think this behavior should be retained.
Co-authored-by: Gabrielius Laurinavičius <[email protected]>
Co-authored-by: Gabrielius Laurinavičius <[email protected]>
I think it's ready to review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but would you consider making the same or similar additions to admin2? We're trying to reach feature parity between the two. I'm ready to merge this either way.
@jlillis, I can add such things to admin2, but afaik the lists are a little bit different in admin2. |
Looks like there's a merge conflict blocking this - could you resolve? |
@jlillis done |
After merged, this PR will add a filter to the following lists:
Before:

After:

IMHO we don't need to add this to admin2, because their lists are a little bit different.