Lua linter implementation #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice |
|
Let's trial it for a month and see how this works out in practise (for PR's & MTA's Lua stack).. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fast Q&A to my PR
What is it? - https://en.wikipedia.org/wiki/Lint_(software)
Why is it need for us? - This repo is a library of examples for newbies and other scripters I think it must be pure and clear for all, even for our GC.
Is it need to merge now? - Not necessary. But if you want to see red crossmark on each commit about fixing the problems, you can. Anyway, you can set it as a "Draft".
How it looks? - https://github.com/Disinterpreter/mtasa-resources/runs/3697351842
Why are you ignore lot of marks in config? - Linter right now uses for common lua, and it hasn't our functions/variables/tables. We can fork it and change later.
Linter: https://github.com/mpeterv/luacheck