Skip to content

Conversation

sacr1ficez
Copy link
Contributor

@sacr1ficez sacr1ficez commented Oct 16, 2021

  • Replaced bound element to predefined resourceRoot
  • Used startedResource from parameters instead of method call getThisResource()
  • Loop isn't called anymore when resource can't stop other resources (missing perms)
  • Also it's no longer in it's scope (perm check)
  • Replaced ipairs with better equivalent
  • Improved readability

Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes minor and optional - I think this is good to merge in a few days as-is if nobody else has blocking comments.

@sacr1ficez
Copy link
Contributor Author

@jlillis done.

@ArranTuna ArranTuna merged commit 7955351 into multitheftauto:master Nov 17, 2021
@sacr1ficez sacr1ficez deleted the gamemodestopper-fix branch November 17, 2021 17:04
@patrikjuvonen patrikjuvonen added this to the 1.6 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants