Skip to content

Conversation

sacr1ficez
Copy link
Contributor

@sacr1ficez sacr1ficez commented Nov 3, 2021

  • Fixed pickup event handler (the code never passed through matchingDimension check because it was always nil).
  • get methods are now called just on script init & when certain setting changes in resource.
  • Improved readability & optimisation.

Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Use of temporary variables makes this script longer than it needs to be, but perhaps more readable. Changes requested are minor and optional. Ready for merge later this week absent any other blocking comments.

@ArranTuna ArranTuna merged commit aa9782e into multitheftauto:master Nov 18, 2021
@sacr1ficez sacr1ficez deleted the deathpickups-fix branch November 18, 2021 16:22
@patrikjuvonen patrikjuvonen added this to the 1.6 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants