Skip to content

Conversation

ArranTuna
Copy link
Contributor

Just fixed the "previously defined" warnings in [admin] and seeing how to make PR. I'm unsure as to the need for "previously defined" warnings to be fixed, some seem less necessary to be fixed than others.

@TheNormalnij
Copy link
Member

Looks good to me

@ArranTuna
Copy link
Contributor Author

I think I made this PR in the wrong way because I had to create a branch to create this PR and yet there aren't other branches for PR's so I'm guessing I have to clone the repository and make branches in the clone for PRs?

@ArranTuna ArranTuna merged commit 3ed3219 into master Nov 18, 2021
@ArranTuna ArranTuna deleted the admin-previously-defined-fixes branch November 18, 2021 16:08
@patrikjuvonen patrikjuvonen added this to the 1.6 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants