Skip to content

scoreboard: Trigger events improvements #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2023
Merged

scoreboard: Trigger events improvements #403

merged 2 commits into from
Jan 16, 2023

Conversation

sacr1ficez
Copy link
Contributor

@sacr1ficez sacr1ficez commented Jan 15, 2023 •
edited
Loading

  • Replaced client triggerServerEvent with onPlayerResourceStart.
  • Changed event sources from root to lowest possible element.
  • Use shared type for dxscoreboard_shared.lua in meta.xml, instead of twice defining it.

@jlillis jlillis merged commit 9be00d6 into multitheftauto:master Jan 16, 2023
@sacr1ficez sacr1ficez deleted the scoreboard-fix branch January 17, 2023 11:48
@patrikjuvonen patrikjuvonen added this to the 1.6.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement resource:scoreboard
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sacr1ficez @jlillis @patrikjuvonen