IP2C standalone resource #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move ip2c inside [admin] + Remove admin2 ip2c implementation + fix getPlayerCountry call in admin admin_server.lua + fix update admin panel when IP2C starts/stops + update gitignore
|
Let me know if you want anything changed, I'm all ears. |
… if any unknown codes in CSV There are no unknown country codes in CSV now, it's good 👍
Co-Authored-By: srslyyyy <[email protected]>
Andorra flag was wrong, multitheftauto#318 Co-Authored-By: srslyyyy <[email protected]>
Images from Wikipedia Resized with https://www.iloveimg.com/resize-image#resize-options,pixels Tested, getPlayerCountry and getCountryName working multitheftauto#318
Dutchman101
previously requested changes
Jan 21, 2023
There was a problem hiding this comment.
We're awaiting feedback from this convo on development discord:
Either option has to be implemented, requesting input from @jlillis (AGENT_STEELMEAT)
Fernando-A-Rocha
force-pushed
the
ip2c-standalone-resource
branch
from
4d48b98 to
aeb79eb
Compare
This reverts commit aeb79eb.
Outputs server log deprecation warning if any external scripts call this function.
brenodanyel
reviewed
Jan 23, 2023
jlillis
approved these changes
Jan 25, 2023
This was referenced Jan 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
ip2cresource #222)Description
ip2c is an optional resource that, when running, will fetch player countries via IP using a list provided by MTA HQ.
It can also convert country code to country name using the ISO 3166 standard.
admin & admin2 are responsible for starting/stopping ip2c based on resource setting "*useip2c".
scoreboard detects when ip2c is started/stopped.
Note
MTA HQ IpToCountryCompact.csv (Direct download link) - used in ip2c/server.lua.
Thank you