Skip to content

scoreboard: Further improvements #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2023
Merged

scoreboard: Further improvements #407

merged 2 commits into from
Jan 24, 2023

Conversation

sacr1ficez
Copy link
Contributor

  • Optimised code (replaced ipairs to range loops, localized some variables/tables and function; reduced function calls e.g guiGetScreenSize was called constantly, although it never changes without a reconnect)
  • Deleted unused (cBlack)/dupped (MAX_PRIORITY_SLOT) variables.
  • Introduced return early in some places to reduce nesting.

@Fernando-A-Rocha
Copy link
Contributor

Tested, scoreboard functions fine.

jlillis
jlillis approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, actually made a noticeable improvement.

@jlillis jlillis merged commit 3d3c592 into multitheftauto:master Jan 24, 2023
@sacr1ficez sacr1ficez deleted the scoreboard-further-improvements branch January 25, 2023 00:01
@patrikjuvonen patrikjuvonen added this to the 1.6.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlillis jlillis jlillis approved these changes

Assignees
No one assigned
Labels
enhancement resource:scoreboard
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sacr1ficez @Fernando-A-Rocha @jlillis @patrikjuvonen