Skip to content

editor_main: Fix version warning #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 28, 2023
Merged

editor_main: Fix version warning #408

merged 4 commits into from
Jan 28, 2023

Conversation

sacr1ficez
Copy link
Contributor

@sacr1ficez sacr1ficez commented Jan 22, 2023 •
edited
Loading

This PR fixes version warning introduced in #385

obraz

reported by @brenodanyel

jlillis
jlillis requested changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we ought to fetch the min_mta_version used by the editor resource so we're not hunting for this line of code each time we need to bump the version.

@sacr1ficez sacr1ficez changed the title editor: Fix version warning editor_main: Fix version warning Jan 25, 2023
@sacr1ficez sacr1ficez requested a review from jlillis January 25, 2023 02:27
@jlillis jlillis merged commit 29e1ae0 into multitheftauto:master Jan 28, 2023
@sacr1ficez sacr1ficez deleted the editor-ver-fix branch January 28, 2023 01:42
@patrikjuvonen patrikjuvonen added this to the 1.6.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlillis jlillis jlillis approved these changes

Assignees
No one assigned
Labels
enhancement resource:editor
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sacr1ficez @jlillis @patrikjuvonen