Skip to content

scoreboard: Fix performance regression in getCursorScoreboardPosition #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023
Merged

scoreboard: Fix performance regression in getCursorScoreboardPosition #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions [gameplay]/scoreboard/dxscoreboard_rt.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,28 +8,35 @@ local rt
local lastUpdateTime = 0
local savedRowsNext = {}
local savedRows = {}
local cursorCache = {}

-- Adjust cursor position if using rt

local function getCursorScoreboardPosition(rtPass)
local cX, cY = getCursorPosition()
local sX, sY = SCREEN_X, SCREEN_Y

cX, cY = cX * sX, cY * sY

if rtPass then
local x, y = scoreboardGetTopCornerPosition()
if #cursorCache == 0 then
local cX, cY = getCursorPosition()
local sX, sY = SCREEN_X, SCREEN_Y

cX, cY = cX * sX, cY * sY

if rtPass then
local x, y = scoreboardGetTopCornerPosition()

cX, cY = cX - x, cY - y
cX, cY = cX - x, cY - y
end

cursorCache = {cX, cY}
end

return cX, cY
return cursorCache[1], cursorCache[2]
end

-- drawScoreboard
-- Do things depending on things

function drawScoreboard()
cursorCache = {}

if #savedRowsNext > 0 then
savedRows = savedRowsNext
savedRowsNext = {}
Expand Down