Skip to content

editor: Fix EDF custom elements rotation issues on undo/manual Adjustment #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2024
Merged

editor: Fix EDF custom elements rotation issues on undo/manual Adjustment #546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cf3282
Fix EDF custom elements have wrong rotation
q8X Sep 3, 2024
fd017fb
fix whitespaces
q8X Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions [editor]/move_keyboard/move_keyboard.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,9 @@ function attachElement(element)
posX, posY, posZ = getElementPosition(element)
movementType = MOVEMENT_MOVE

-- Clear the quat rotation when attaching to element
exports.editor_main:clearElementQuat(selectedElement)

if (getElementType(element) == "vehicle") or (getElementType(element) == "object") then
rotX, rotY, rotZ = getElementRotation(element, "ZYX")
elseif (getElementType(element) == "player") or (getElementType(element) == "ped") then
Expand All @@ -420,6 +423,9 @@ function detachElement()
if (selectedElement) then
disable()

-- Clear the quat rotation when detaching from element
exports.editor_main:clearElementQuat(selectedElement)

-- fix for local elements
if not isElementLocal(selectedElement) then
-- sync position/rotation
Expand Down