Fix chat messages sent twice #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Other game modes that handle onPlayerChat and change its output to chatbox are:
Then, |
Contributor
|
Appropriate fix for while we wait for the large scale changes discussed in #463 |
Contributor
Author
|
Exactly, this can be merged now. |
jlillis
requested changes
Oct 19, 2024
Contributor
Author
|
There you have it @jlillis |
jlillis
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
playercolors will no longer handle chat, as this is handled in the gamemode resource itself (freeroam), playercolors is just an extra resource.
@Dark-Dragon @Nico8340