Refactor headshot #591
Merged
Refactor headshot #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Fernando-A-Rocha
left a comment
Fernando-A-Rocha
left a comment
There was a problem hiding this comment.
Overall good job!! But
Member
|
Please remove all comments, headers (of where it's part of, etc), and documentation/scripting guide lines, and make it clean code only. Thanks for the effort put into these things but im only requesting this because i's not an established practise within other official resources, and to keep things as uniform as possible. Also, in new resources, we now use this for meta.xml: |
Member
Author
|
Done @Dutchman101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the headshot resource, breaks it into several parts, provides runtime modifiable settings, detailed documentation and examples.